Repoquery the test repo in prepare phase #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpopelka
force-pushed
the
empty-repoquery
branch
2 times, most recently
from
2cacb84
to
a0dfbd0
Compare
We check it before running tests https://github.com/fedora-ci/mini-tps/blob/main/mtps-run-tests#L174 but better fail sooner. There's not much we can do when this problem happens. We would need to disable the correct module but that might (e.g. in python27 module case) break other packages dependencies. So just warn the user.
jpopelka
force-pushed
the
empty-repoquery
branch
from
a0dfbd0
to
c37f553
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We check it before running tests but better fail sooner.
There's not much we can do when this problem happens.
We would need to disable the correct module but that might (e.g. in python27 module case) break other packages dependencies.
So just warn the user.