Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install which and procps-ng in prepare-system (all profiles) #30

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

AdamWill
Copy link
Contributor

@AdamWill AdamWill commented Dec 5, 2023

The scripts use which and ps, but do not make sure they are available. In e.g. official Fedora base container images, they are not, so the test pipeline fails when run in a container.

The scripts use `which` and `ps`, but do not make sure they are
available. In e.g. official Fedora base container images, they
are not, so the test pipeline fails when run in a container.

Signed-off-by: Adam Williamson <[email protected]>
@AdamWill
Copy link
Contributor Author

AdamWill commented Dec 5, 2023

For local testing of the thing I'm working on I did this in prepare.sh of the pipeline, but it seems like this would be 'more correct' as a permanent fix. The package names are the same all the way back to at least RHEL 7.

@thrix thrix requested review from Andrei-Stepanov, msrb, jpopelka and thrix and removed request for Andrei-Stepanov December 12, 2023 11:16
Copy link
Contributor

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpopelka jpopelka merged commit ff6e45d into fedora-ci:main Dec 12, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants