Typos and other cleanup #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and not glowing-waffles, removed unused utils/, and changed visualization to include various source code that was being ignored.
…eingProfileWidget as exported class.
…ource code to allow it to be imported.
…stellarphot into typos_and_other_cleanup
…ias has been removed on recent numpy.
Add blank line at end of imports Co-authored-by: Matt Craig <[email protected]>
Also adds blank line at end. Co-authored-by: Matt Craig <[email protected]>
Add space before class declaration. Co-authored-by: Matt Craig <[email protected]>
mwcraig
approved these changes
May 30, 2023
|
Thanks, @JuanCab |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I have worked to do the following:
__all__list) most of their functions and classes. This also required editing some of the__init__.pysource files to import the source files. Most of the changes were invisualizationdirectory ofstellarphot.stellarphotand notglowing-wafflesdocumentation and also to search in additional source code locations (notablyanalysis.pyandsource_detection.py.coordinates.pyfile which defined one function used in one spot inphotometry.pyonce. Added the call to retrieve WCS data directly tophotometry.py.np.float,np.int, andnp.boolreplaced withfloat,int, andboolrespectively since those aliases were deprecated in NumPy 1.20 and removed in NumPy 1.24.