Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sourcelist input option to comparison #431

Conversation

mwcraig
Copy link
Contributor

@mwcraig mwcraig commented Aug 17, 2024

This is the last step needed to make exoplanet photometry as functional as it was in stellarphot 1.4.X.

Also it adds the spinner to a notebook.

@mwcraig mwcraig added this to the 2.0.0-beta milestone Aug 17, 2024
@mwcraig mwcraig requested a review from JuanCab August 17, 2024 23:05
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.13%. Comparing base (15e5e19) to head (347d8c2).
Report is 111 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #431      +/-   ##
==========================================
+ Coverage   79.93%   80.13%   +0.20%     
==========================================
  Files          30       30              
  Lines        3892     3912      +20     
==========================================
+ Hits         3111     3135      +24     
+ Misses        781      777       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@JuanCab JuanCab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell. I had to dig into an astropy command I was less familiar with and understand a bit of why you split up _set_file, but it seems sound.

@mwcraig mwcraig merged commit 325124b into feder-observatory:main Aug 18, 2024
18 checks passed
@mwcraig mwcraig deleted the add-sourcelist-input-option-to-comparison branch August 18, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants