Include proper files in sdist so they land in the wheel #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b1528dd. Turns out that because get_pkg_data_filename is used to get the photometry runner notebook at least one of these is needed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #407 +/- ##
=======================================
Coverage 78.87% 78.87%
=======================================
Files 29 29
Lines 3815 3815
=======================================
Hits 3009 3009
Misses 806 806 ☔ View full report in Codecov by Sentry. |
|
I'm going to go ahead and merge this to get alpha1 out.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #406. The fundamental issue was that the wheel is built from the sdist, and the sdist did not include the logo or jupyter-app-launcher, so the wheel didn't include them. Unfortunate that wheel building didn't raise an error when it didn't find the files, but the missing files are in the sdist now, and a duplicate entry in the wheel section was removed.
Also removes a couple ofTurns out at least one of them is necessary because we use__init__.pythat are really unnecessary and were ending up in the environment's jupyter data folder.get_pkg_data_filenameto get the location of the photometry runner notebook.