Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AAVSO filter list to match latest AAVSO update #393

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

mwcraig
Copy link
Contributor

@mwcraig mwcraig commented Jul 31, 2024

This also fixes #382 because the duplicate R and I entries have been removed.

I think the definitive source of filter names is https://www.aavso.org/filters -- I've asked in the AAVSO slack to make sure.

Another quickie @JuanCab 😬 -- good news is that there are not very many open issues milestoned to 2.0.0 left 😀

This also fixes feder-observatory#382 because the duplicate R and I entries have been
removed.
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.91%. Comparing base (76e2223) to head (0b48d97).
Report is 226 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #393   +/-   ##
=======================================
  Coverage   51.91%   51.91%           
=======================================
  Files          56       56           
  Lines        5835     5836    +1     
=======================================
+ Hits         3029     3030    +1     
  Misses       2806     2806           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@JuanCab JuanCab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mwcraig mwcraig merged commit efb4a05 into feder-observatory:main Jul 31, 2024
12 checks passed
@mwcraig mwcraig deleted the fix-aavso-filter-list branch July 31, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeated entries in AAVSO filters for PassbandMap
2 participants