Refactor title decoration #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this, the _testing_path argument can be removed from saved settings code. The alternative to going this route was to add _testing_path to another class, the ReviewSettings widget.
This will make it easy to reuse for decorating accordion or tab titles. The original version could only decorate an HTML widget that it had created.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
==========================================
+ Coverage 77.67% 77.69% +0.02%
==========================================
Files 27 27
Lines 3628 3632 +4
==========================================
+ Hits 2818 2822 +4
Misses 810 810 ☔ View full report in Codecov by Sentry. |
JuanCab
previously approved these changes
Jun 13, 2024
| @@ -1,6 +1,18 @@ | |||
| # Some settings require custom widgets to be displayed in the GUI. These are defined in | |||
| # this module. | |||
|
|
|||
| # This workaround is for Python < 3.11. It is not needed in Python 3.11 and later. | |||
There was a problem hiding this comment.
Couldn't we just require 3.11? I think we opted to require 3.10 last summer, but at this point... In any case, if you are wedded to supporting 3.10, keep this.
There was a problem hiding this comment.
We could require 3.11. I wasn't aware until I opened this PR that StrEnum was new in 3.11.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it easy to reuse for decorating accordion or tab titles. The original version could only decorate an HTML widget that it had created.
#372 should be merged before this one is.