-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed spellings in autoui_widget_viewer.upynb and stellarphot/core.py #367
Conversation
…/photometry/photometry.py
…otometry/05-relative-flux-calculation-template.ipynb
…ansit-fit-with-exotic.ipynb
…f what it was reporting as mispelled.
@JuanCab -- can you try rebasing this to remove the conflict? Not sure why none of the tests are running either... |
for more information, see https://pre-commit.ci
…f what it was reporting as mispelled.
Looks like there is still one spelling error.... |
…late_aavso_mags_draft.ipynb
Not sure why that happened, but things are fixed and I suspect this will will now pass the tests. In the process of fixing the merge, I discovered one file failing the codespell check, so that has been fixed as well. |
Fixed now with commit 290e646 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #367 +/- ##
=======================================
Coverage 76.48% 76.48%
=======================================
Files 27 27
Lines 3665 3665
=======================================
Hits 2803 2803
Misses 862 862 ☔ View full report in Codecov by Sentry. |
This PR fixes a bunch of typos (and in some cases, troublesome variable names that are confused for typos) that were caught by codespell. This should reduce the number of failed codespell checks dramatically. :).
I also updated
ignore-words.txt
to not flag some words we legitimately misspell. :)