Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed spellings in autoui_widget_viewer.upynb and stellarphot/core.py #367

Merged
merged 26 commits into from
Jun 5, 2024

Conversation

JuanCab
Copy link
Contributor

@JuanCab JuanCab commented Jun 5, 2024

This PR fixes a bunch of typos (and in some cases, troublesome variable names that are confused for typos) that were caught by codespell. This should reduce the number of failed codespell checks dramatically. :).

I also updated ignore-words.txt to not flag some words we legitimately misspell. :)

Juan Cabanela added 20 commits June 5, 2024 14:30
…otometry/05-relative-flux-calculation-template.ipynb
@JuanCab JuanCab added the linting label Jun 5, 2024
@JuanCab JuanCab requested a review from mwcraig June 5, 2024 20:05
@mwcraig
Copy link
Contributor

mwcraig commented Jun 5, 2024

@JuanCab -- can you try rebasing this to remove the conflict? Not sure why none of the tests are running either...

@mwcraig
Copy link
Contributor

mwcraig commented Jun 5, 2024

Looks like there is still one spelling error....

@JuanCab
Copy link
Contributor Author

JuanCab commented Jun 5, 2024

Not sure why that happened, but things are fixed and I suspect this will will now pass the tests. In the process of fixing the merge, I discovered one file failing the codespell check, so that has been fixed as well.

@JuanCab
Copy link
Contributor Author

JuanCab commented Jun 5, 2024

Looks like there is still one spelling error....

Fixed now with commit 290e646

Copy link
Contributor

@mwcraig mwcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.48%. Comparing base (63b1fe9) to head (290e646).
Report is 255 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #367   +/-   ##
=======================================
  Coverage   76.48%   76.48%           
=======================================
  Files          27       27           
  Lines        3665     3665           
=======================================
  Hits         2803     2803           
  Misses        862      862           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwcraig mwcraig merged commit 69db392 into feder-observatory:main Jun 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants