Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ruff and black precommit revs and added codespell to precommit. #366

Merged
merged 7 commits into from
Jun 5, 2024

Conversation

JuanCab
Copy link
Contributor

@JuanCab JuanCab commented Jun 5, 2024

I have updated the precommit config yaml to include codespell in the recommit as well as manually updating the repo rev for ruff and black in the precommit.

I also added precommit.ci as an app for stellarphot (both for feder-observatory and JuanCab), which should do weekly checks on the precommit rev versions and issue PR when there is an update to the rev on one of our recommits.

@JuanCab JuanCab added tests Issue related to tests linting labels Jun 5, 2024
@JuanCab JuanCab requested a review from mwcraig June 5, 2024 18:59
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.48%. Comparing base (25c1ec5) to head (63b1fe9).
Report is 263 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #366   +/-   ##
=======================================
  Coverage   76.48%   76.48%           
=======================================
  Files          27       27           
  Lines        3665     3665           
=======================================
  Hits         2803     2803           
  Misses        862      862           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mwcraig mwcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good -- should we make the changes to spelling that codespell suggests? And maybe add some codespell exceptions:

  • It is spell checking the SVG logo file
  • It is trying to change TOI to something else.

I think there is a way to add exceptions to pyproject.toml...

@JuanCab
Copy link
Contributor Author

JuanCab commented Jun 5, 2024

This looks good -- should we make the changes to spelling that codespell suggests? And maybe add some codespell exceptions:

  • It is spell checking the SVG logo file
  • It is trying to change TOI to something else.

I think there is a way to add exceptions to pyproject.toml...

I can work on the exceptions, but where are you seeing codespell's suggestions?

Copy link
Contributor

@mwcraig mwcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@mwcraig mwcraig merged commit f4384ea into feder-observatory:main Jun 5, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linting tests Issue related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants