-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated ruff and black precommit revs and added codespell to precommit. #366
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #366 +/- ##
=======================================
Coverage 76.48% 76.48%
=======================================
Files 27 27
Lines 3665 3665
=======================================
Hits 2803 2803
Misses 862 862 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good -- should we make the changes to spelling that codespell suggests? And maybe add some codespell exceptions:
- It is spell checking the SVG logo file
- It is trying to change TOI to something else.
I think there is a way to add exceptions to pyproject.toml...
I can work on the exceptions, but where are you seeing codespell's suggestions? |
…configuration to support that.
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good!
I have updated the precommit config yaml to include codespell in the recommit as well as manually updating the repo rev for ruff and black in the precommit.
I also added precommit.ci as an app for stellarphot (both for feder-observatory and JuanCab), which should do weekly checks on the precommit rev versions and issue PR when there is an update to the rev on one of our recommits.