Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to UI generator #362

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

mwcraig
Copy link
Contributor

@mwcraig mwcraig commented Jun 3, 2024

This PR adds the option of setting the width of input fields and FileChooser fields to a value smaller than the default maximum. This is handy for making things look nice in the comparison star chooser notebook, coming soon....

@mwcraig mwcraig added the UI 🤮 label Jun 3, 2024
@mwcraig mwcraig requested a review from JuanCab June 3, 2024 19:56
@mwcraig mwcraig self-assigned this Jun 3, 2024
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.48%. Comparing base (eef79aa) to head (25c1ec5).
Report is 284 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
+ Coverage   76.01%   76.48%   +0.46%     
==========================================
  Files          27       27              
  Lines        3611     3665      +54     
==========================================
+ Hits         2745     2803      +58     
+ Misses        866      862       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JuanCab
JuanCab previously approved these changes Jun 3, 2024
Copy link
Contributor

@JuanCab JuanCab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, well, except for typos in comments.

stellarphot/settings/tests/test_views.py Outdated Show resolved Hide resolved
stellarphot/settings/tests/test_views.py Outdated Show resolved Hide resolved
@mwcraig
Copy link
Contributor Author

mwcraig commented Jun 3, 2024

Thanks, I'll push the typo fixes then merge...

@mwcraig mwcraig merged commit acdf251 into feder-observatory:main Jun 3, 2024
8 of 9 checks passed
@mwcraig mwcraig deleted the add-view-feature branch June 3, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants