Disentangling file and console logging #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 24, 2024 10:20
…y separately from console logging.
… the full path is passed to single_image_photometry.
…ry logging (logfile disappears during test).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #359 +/- ##
==========================================
+ Coverage 75.33% 76.01% +0.68%
==========================================
Files 27 27
Lines 3608 3611 +3
==========================================
+ Hits 2718 2745 +27
+ Misses 890 866 -24 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addressed Issue #271 separating the logic for when file logging and console logging happen so you can, for example, have file logging without console logging.
I have also written tests to check that the logging happens. These tests are a little different from previous tests I have written in that they capture stderr to determine if the appropriate console logging happened (they also check that the files that are written contain some of the appropriate content).