-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve profile tests and use a cutout when possible #354
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #354 +/- ##
==========================================
+ Coverage 75.20% 75.33% +0.12%
==========================================
Files 27 27
Lines 3594 3608 +14
==========================================
+ Hits 2703 2718 +15
+ Misses 891 890 -1 ☔ View full report in Codecov by Sentry. |
49455b5
to
8e53a68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly comments needing changes, although it does have me wondering although it has me wondering if there should be a check in the code for the cutout being too small to correctly fit the profile?
|
||
|
||
def test_radial_profile_bigger_profile_than_cutout(): | ||
# Test that the cutout, used for finding the star, can be smaller than |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not following how this is a test that the cutoff can be smaller than the profile radius.
From reviewing the code of this test, it looks like you are testing that if the cutout is smaller than needed for the profile radius, the size of the cutout will be adjusted accordingly. Can you clarify the comment accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the changes look good.
This PR does three things:
find_center
fails badly if the star is faint #352)CenterAndProfile
for calculating the profile to improve performance (fixesCenterAndProfile
is slow... #331)