Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly set widget value when making a new item #318

Merged
merged 1 commit into from
May 3, 2024

Conversation

mwcraig
Copy link
Contributor

@mwcraig mwcraig commented May 3, 2024

This fixes #317 by setting the ipyautoui widget to the appropriate value when making a new item.

@JuanCab @Tanner728 -- I'm going to merge this in the morning if tests pass so that I can finally get this custom widget wrapped up, but if you want to try this out here are the steps:

  1. Make a camera. (or observatory or..._
  2. Save it.
  3. Once the dropdown updates, select "Make a new..."
  4. Select the item you made in step 1.

Prior to this fix you got a bunch of blank fields in step 4. Now it works.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.87%. Comparing base (d901d65) to head (b388fcc).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #318   +/-   ##
=======================================
  Coverage   73.86%   73.87%           
=======================================
  Files          27       27           
  Lines        3409     3410    +1     
=======================================
+ Hits         2518     2519    +1     
  Misses        891      891           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Tanner728 Tanner728 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick test of this and it works as expected.

@mwcraig mwcraig merged commit a7415f6 into feder-observatory:main May 3, 2024
9 checks passed
@mwcraig mwcraig deleted the fix-new-value branch May 3, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Making a new item confuses the widget
3 participants