Improve handling of revert button enabled state #314
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a mistake I think made in #310. in handling whether the save and revert buttons in the button bar were enabled.
In that PR I made it so that the save and revert buttons were enabled only if:
That makes sense for the save button -- you should only be able to save a valid model.
Requiring the widget hold a valid pydantic for the revert button makes little sense. One of the reasons you might want to revert, after all, is that you have accidentally entered one or more invalid fields.
This PR changes the behavior for the revert button so that it is enabled whenever there are unsaved changes.
@JuanCab and @Tanner728 -- a look at the code would be great, but confirmation that this new logic makes sense would be enough...I'm reasonably confident the code does what it should.