Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix observatory widget #284

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

mwcraig
Copy link
Contributor

@mwcraig mwcraig commented Mar 11, 2024

This fixes #281 b y disabling continuous_update for most entry widgets.

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.31%. Comparing base (4dabd8d) to head (f57ac2f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
+ Coverage   71.29%   71.31%   +0.02%     
==========================================
  Files          25       25              
  Lines        3100     3103       +3     
==========================================
+ Hits         2210     2213       +3     
  Misses        890      890              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwcraig mwcraig requested a review from JuanCab March 11, 2024 19:54
Copy link
Contributor

@JuanCab JuanCab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seem to be mostly documentation and for the auto_widget_viewer.ipynb notebook just changing the name of the PhotometyOptions to PhotometryOptionalSettings (the new name for those settings). Seems completely reasonable stuff.

@mwcraig
Copy link
Contributor Author

mwcraig commented Mar 13, 2024

This is really the only functional bit:

    for widget in ui.di_widgets.values():
        if hasattr(widget, "continuous_update"):
            widget.continuous_update = False

It prevents the AutoUi widget from trying to force the string representation of values into the widget as you are trying to type. That was really annoying and made it essentially impossible to edit a value like latitude that had correct units but an incorrect value.

@mwcraig mwcraig merged commit f1bffcd into feder-observatory:main Mar 13, 2024
9 checks passed
@mwcraig mwcraig deleted the fix-observatopry-widget branch April 6, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Observatory input form is unusable
3 participants