Move Camera into the settings module #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
==========================================
+ Coverage 55.87% 55.90% +0.02%
==========================================
Files 24 25 +1
Lines 2960 2962 +2
==========================================
+ Hits 1654 1656 +2
Misses 1306 1306 ☔ View full report in Codecov by Sentry. |
JuanCab
approved these changes
Jan 10, 2024
| Examples | ||
| -------- | ||
| >>> from astropy import units as u | ||
| >>> from stellarphot.settings import Camera |
There was a problem hiding this comment.
Good, you caught this change (of course the tests would not pass without it).
There was a problem hiding this comment.
I confirmed the functions didn't appear to change in their migration.
There was a problem hiding this comment.
Confirmed Camera model didn't appear to change in migration except as needed.
There was a problem hiding this comment.
Confirmed tests appear to have migrated intact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR doesn't change any functionality, it simply moves the
Cameraobject fromcore.pyintosettings/models.py, and moves the more generic astropy/pydantic stuff intosettings/astropy_pydantic.py. Having all the pydantic-related stuff inone place makes a little more sense to me, and perhaps reduces (a tiny bit) the pain of updating to pydantic 2.