Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isort #250

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Add isort #250

merged 2 commits into from
Jan 9, 2024

Conversation

mwcraig
Copy link
Contributor

@mwcraig mwcraig commented Jan 9, 2024

This PR sorts the import statements at the top of each file in a particular order.

Big picture, imports from Python standard library are in the first group, imports from other packages are in the second group, and imports from stellarphot are in the third group.

Within each group, lines that start import committee first, then lines that start from ... import .... Within each of those groupings imports are arranged alphabetically.

A check of isort has been turned on in ruff.

What this means in practice: You will need to pull in the latest main branch from feder-observatory to your local git clone before opening any new PRs. To do that, navigate in a terminal to your git clone and

git checkout main
git pull --set-upstream --ff-only upstream main 

@JuanCab @Tanner728 @AbigaleMoen @WatsonEmily11 @MDeRung2021

@mwcraig mwcraig merged commit 010b90b into feder-observatory:main Jan 9, 2024
9 checks passed
@mwcraig mwcraig deleted the add-isort branch February 8, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant