Fix bug in catalog search functionality and make comparison notebook compatible with CatalogData
#242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes feder-observatory#241 by allowing the location for a catalog search to be given as a WCS. Tests for setting the location were also added, as was a test for the case when a FITS header has no WCS.
This should have been done when the new CatalogData was implemented in
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #242 +/- ##
==========================================
+ Coverage 54.51% 55.22% +0.70%
==========================================
Files 23 23
Lines 2911 2959 +48
==========================================
+ Hits 1587 1634 +47
- Misses 1324 1325 +1 ☔ View full report in Codecov by Sentry. |
JuanCab
reviewed
Jan 3, 2024
Addresses a review comment pointing out that we already use "location" for the observatory.
|
I think I've addressed all of your comments, thanks for the review! |
JuanCab
reviewed
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR started as a way to get the comparison notebook working again. Along the way I found a couple of issues in
CatalogData.from_vizierthat needed fixing.Fixes #241