Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix photometry test data #239

Merged
merged 2 commits into from
Jan 1, 2024

Conversation

mwcraig
Copy link
Contributor

@mwcraig mwcraig commented Jan 1, 2024

There was an error in the way the photometry test data was being created that led to a Time column not being savable.

@mwcraig mwcraig added the tests Issue related to tests label Jan 1, 2024
@mwcraig mwcraig requested a review from JuanCab January 1, 2024 18:13
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (386301d) 54.44% compared to head (8fcdb22) 54.44%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #239   +/-   ##
=======================================
  Coverage   54.44%   54.44%           
=======================================
  Files          23       23           
  Lines        2911     2911           
=======================================
  Hits         1585     1585           
  Misses       1326     1326           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwcraig
Copy link
Contributor Author

mwcraig commented Jan 1, 2024

Self-merging since this is pretty small...

@mwcraig mwcraig merged commit 4f371b2 into feder-observatory:main Jan 1, 2024
9 checks passed
Copy link
Contributor

@JuanCab JuanCab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

@mwcraig mwcraig deleted the fix-photometry-test-data branch February 8, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Issue related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants