Fix all warnings #203
Merged
Fix all warnings #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This used a deprecated version class from distutils, and ought to be enforced these days by conda and/or pip anyway.
mwcraig
force-pushed
the
fix-warnings
branch
from
e128079 to
996bfb4
Compare
As opposed to an array of coordinates with length 1
This will hopefully make the tests a bit more deterministic -- without it I see some failures related to fitting a gaussian to image sources, which I'm guessing is related to the particular set of images values in those cases.
Turns out we were leaving some files open during tests. In addition, every time we load a wcs during these tests we get a warning that the number of WCS axes does not match the number of image axes, which is on purpose -- we want a full-frame WCS but do not want to have to carry around a full frame image in the repo.
Some of our test cases are odd and are expected to generate warnings about the quality of the fit.
mwcraig
force-pushed
the
fix-warnings
branch
from
117f2a6 to
e42be8e
Compare
mwcraig
added a commit
to mwcraig/stellarphot
that referenced
this pull request
Dec 12, 2023
These did not cleanly transfer over when I rebased on top of feder-observatory#203
mwcraig
added a commit
to mwcraig/stellarphot
that referenced
this pull request
Dec 16, 2023
These did not cleanly transfer over when I rebased on top of feder-observatory#203
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
pytestsettings inpyproject.toml