Added a pydantic-validated Camera class and test. #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwcraig
requested changes
Aug 27, 2023
There was a problem hiding this comment.
Despite the extensive comments I think this is really close to ready. Sorry it took a while -- I needed some uninterrupted time so I could try things locally since I'm not that familiar with pydantic or Quantity.
In addition to the line suggestions, I have one other:
Add an "image_unit" attribute to Camera so that the user has the option of using whatever image unit that want (ADU, count, something that is already gain correct so that it is in electrons, say)
What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a pydantic (v1) validated Camera class. I also had to modify previous units checks (we now through
ValueErrorinstead ofTypeError) and added a new check to see that any 'count' (e.g. count or electron or whatever) is acceptable as long as the units of read_noise, gain, and dark_current are consistent.I also confirmed we can json serialize the Camera object, so we can dump its value to disk and should be able to deserialize it easily enough.