Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial reorganization of code #130

Merged
merged 8 commits into from
Jul 15, 2023
Merged

Conversation

JuanCab
Copy link
Contributor

@JuanCab JuanCab commented Jul 10, 2023

As part of the refactoring, I have performed an initial code reorganization:

  • I moved functions in visualization to gui_tools and plotting
  • I moved some functions from other directories to utils
    • Moved utility functions for stellar comparisons: read_file, set_up, crossmatch_APASS2VSX, mag_scale, and in_field moved from gui_tools/comparison_function.py to utils/comparison_utils.py
    • Moved utility functions for catalog searches: catalog_search.py from differential_photometry to utils
    • Moved utility functions for magnitude transforms: magnitude_transforms.py from differential_photometry to utils

In the process of performing these moves, I searched for each call to each function in the source code and fixed all imports to work. I also moved some of the testing files around. I did confirm pytest runs to completion.

Miscellania: I also replaced several import pandas with import pandas as pd and fixed the corresponding function calls as this is fairly standard. I also fixed a deprecated call to the astropy function scale_image which was removed in astropy 2.0!

@JuanCab JuanCab added the refactor Summer 2023 project to rewrite stellarphot label Jul 10, 2023
@JuanCab JuanCab requested a review from mwcraig July 10, 2023 18:45
@mwcraig mwcraig merged commit 9279bb8 into feder-observatory:main Jul 15, 2023
@JuanCab JuanCab self-assigned this Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Summer 2023 project to rewrite stellarphot
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants