Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update seeing profile functions #126

Merged

Conversation

mwcraig
Copy link
Contributor

@mwcraig mwcraig commented Jul 6, 2023

Fixes #123

mwcraig added 2 commits July 6, 2023 09:37
The class was the only thing that uses this function, so it made more
sense to move it inside the class.
@mwcraig mwcraig added the refactor Summer 2023 project to rewrite stellarphot label Jul 6, 2023
@mwcraig mwcraig added this to the Reimplemented data structure milestone Jul 6, 2023
@mwcraig mwcraig merged commit e98be0d into feder-observatory:main Jul 7, 2023
JuanCab added a commit to JuanCab/stellarphot that referenced this pull request Aug 8, 2023
…adialProfile. It throws an error and self.HWHM is now a class @Property that doesn't need to be initialized that way (error introduced in PR feder-observatory#126).
JuanCab added a commit to JuanCab/stellarphot that referenced this pull request Aug 8, 2023
…adialProfile. It throws an error and self.HWHM is now a class @Property that doesn't need to be initialized that way (error introduced in PR feder-observatory#126).
@mwcraig mwcraig deleted the update-seeing-profile-functions branch February 8, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Summer 2023 project to rewrite stellarphot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review stellarphot/visualization/seeing_profile_functions.py for obsolete code and delete it
1 participant