Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid realloc when creating C-style strings #712

Merged

Conversation

mlowicki
Copy link
Collaborator

Pass ref to benefit from underlying specialization - https://doc.rust-lang.org/1.80.1/src/alloc/ffi/c_str.rs.html#279

Copy link
Collaborator

@davidblewett davidblewett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. The test_produce_consume_consumer_nonempty_callback has been flaky.

@davidblewett davidblewett merged commit 964d5b8 into fede1024:master Aug 23, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants