Fix panic on getting config value from NativeConfig #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kafka can return string with multiple \0 chars (seen on Windows x64), and CStr::from_bytes_with_nul panics in that case. String::from_utf8_lossy() handles that ok
|
This change seems to result in getting an extra null character and therefore panicing (on linux) when trying to parse the result into a number. The change in the linked PR fixes it (although that PR also contains a lot of other changes) |
|
@jjh42 yes; it might be simpler to revert this. I ran out of time ironing out the issues upgrading the MSRV to be able to handle this in a better fashion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kafka can return string with multiple
\0chars (seen at least on Windows x64), andCStr::from_bytes_with_nulpanics in that case.String::from_utf8_lossy()handles that ok