Feature/cycle filter #719
Merged
Feature/cycle filter #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make reports filterable by cycle and year * Make totals filterable by cycle * Update unit tests
* Add cycle filters to candidate and committee resources * Remove year filter on candidates until load and expire dates are valid * Move default cycle filtering to web app * Update unit tests
|
Note: Parallel changes to webapp in fecgov/openFEC-web-app#156. |
| parser.add_argument('state', type=str, help='Two digit U.S. State committee is registered in') | ||
| parser.add_argument('committee_id', type=str, action='append', help="Committee's FEC ID") | ||
| parser.add_argument('candidate_id', type=str, action='append', help="Candidate's FEC ID") | ||
| parser.add_argument('state', type=str, action='append', help='Two digit U.S. State committee is registered in') |
There was a problem hiding this comment.
Nitpick, not related to this task: the help text should say "two character", not "two digit".
There was a problem hiding this comment.
Updated. Once the API docs are ready, I think we should have a thorough review of the help text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make all resources filterable by election cycle, and year where appropriate.
[Resolves #701]
[Resolves #706]