add presidential tables for 2008 and 2012 cycles #5480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcaofec
approved these changes
Jun 28, 2023
42 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary (required)
(Include a summary of proposed changes and connect issue below)
Required reviewers
This PR requires a reviewer from database team.
Impacted areas of the application
None
Screenshots
(Include a screenshot of the new/updated features in context (“in the wild”). If it is an interface change, include both before and after screenshots)
Related PRs
Related PRs against other branches:
How to test
download this branch to local server. Run flyway migrate (or create_sample_db).
Make sure migration finish successfully.
log into cfdm_test, make sure the following 18 tables created:
disclosure.pres_ca_cm_sched_a_join_08d
disclosure.pres_nml_ca_cm_link_08d
disclosure.pres_ca_cm_sched_state_08d
disclosure.pres_ca_cm_sched_link_sum_08d
disclosure.pres_nml_sched_a_08d
disclosure.pres_nml_sched_b_08d
disclosure.pres_f3p_totals_ca_cm_link_08d
disclosure.pres_nml_f3p_totals_08d
disclosure.pres_nml_form_3p_08d
disclosure.pres_ca_cm_sched_a_join_12d
disclosure.pres_nml_ca_cm_link_12d
disclosure.pres_ca_cm_sched_state_12d
disclosure.pres_ca_cm_sched_link_sum_12d
disclosure.pres_nml_sched_a_12d
disclosure.pres_nml_sched_b_12d
disclosure.pres_f3p_totals_ca_cm_link_12d
disclosure.pres_nml_f3p_totals_12d
disclosure.pres_nml_form_3p_12d
review the ddl for the following 5 views, make sure it include the 2008 and 2012 presidential tables:
public.ofec_presidential_coverage_date_vw
public.ofec_presidential_by_candidate_vw
public.ofec_presidential_by_state_vw
public.ofec_presidential_financial_summary_vw
public.ofec_presidential_by_size_vw
System architecture updates (if applicable)
(If this pull request changes our current system diagram, include a description of those changes here and create a new ticket to update the system diagram)