refine api key signup page

[jason-upchurch]

Summary (required)

• Resolves Incorporate design/UX and feature flag for API key sign up #4363
• hard coding "required fields" addressed under remove hard coding from API Key signup required fields #4447

refine API key signup elements per completion criteria in #4363

How to test the changes locally

for non developers:

• https://fec-dev-api.app.cloud.gov/developers/

for developers:

• check out branch
• pytest
• run local api
• verify that api signup looks correct per Incorporate design/UX and feature flag for API key sign up #4363 completion criteria.

Impacted areas of the application

List general components of the application that this PR will affect:

• swagger-ui.html
• docs.py

[lbeaufort]

Thanks for your work on this, @jason-upchurch! Before merge, can you remove the extra dev deploy?

openFEC/tasks.py

Lines 145 to 146 in 90097b7

	('dev', lambda _, branch: branch == 'develop'),
	('dev', lambda _, branch: branch == 'feature/4363-api-signup-refinement')

[jason-upchurch]

Thanks for your work on this, @jason-upchurch! Before merge, can you remove the extra dev deploy?

openFEC/tasks.py

Lines 145 to 146 in 90097b7

	('dev', lambda _, branch: branch == 'develop'),
	('dev', lambda _, branch: branch == 'feature/4363-api-signup-refinement')

@lbeaufort we don't want to merge the dev deploy code in. That's there for the benefit of anyone wanting to review on dev. @JonellaCulmer @johnnyporkchops @pkfec can you please make a note in the issue if you do not plan to review? I will make one last amended commit before merge to remove the dev deploy (or redeploy to dev should any reviewers want to inspect my work on dev).

[JonellaCulmer]

@jason-upchurch I don't see any of the changes reflected in the https://fec-dev-api.app.cloud.gov/developers/ link you provided.

[jason-upchurch]

@jason-upchurch I don't see any of the changes reflected in the https://fec-dev-api.app.cloud.gov/developers/ link you provided.

@JonellaCulmer that's because dev has been overwritten many times since I deployed this I think a week or so ago. I'll check with the team and redeploy it for you.

[JonellaCulmer]

Looks good. Thanks @jason-upchurch

[pkfec]

Looks good @jason-upchurch.

[johnnyporkchops]

Looks great!, jut a few minor CSS comments.