Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] build sitemap.xml builder for pdfs in content-s3 bucket #4235

Closed
wants to merge 2 commits into from

Conversation

jason-upchurch
Copy link
Contributor

Summary (required)

  • Resolves #4234

Include a summary of proposed changes.

How to test the changes locally

Impacted areas of the application

List general components of the application that this PR will affect:

Related PRs

List related PRs against other branches:

branch PR
fix/other_pr link
feature/other_pr link

@jason-upchurch jason-upchurch self-assigned this Mar 3, 2020
@codecov-io
Copy link

codecov-io commented Mar 5, 2020

Codecov Report

Merging #4235 into develop will decrease coverage by 0.29%.
The diff coverage is 3.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #4235     +/-   ##
==========================================
- Coverage    90.32%   90.03%   -0.3%     
==========================================
  Files           78       79      +1     
  Lines         7098     7122     +24     
==========================================
+ Hits          6411     6412      +1     
- Misses         687      710     +23
Impacted Files Coverage Δ
webservices/tasks/__init__.py 68% <ø> (ø) ⬆️
...vices/tasks/guidance_document_sitemap_generator.py 0% <0%> (ø)
webservices/tasks/utils.py 74.07% <100%> (-0.93%) ⬇️
webservices/rest.py 91.71% <0%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a04a93a...ff17668. Read the comment docs.

@jason-upchurch jason-upchurch force-pushed the feature/4234-search-s3-pdf branch from 8a921cb to 9e6eeb7 Compare March 5, 2020 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create automated sitemap.xml generation for policy/guidance pdfs
2 participants