Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ScheE endpoint sortable by support_oppose_indicator #3520

Conversation

pkfec
Copy link
Contributor

@pkfec pkfec commented Nov 30, 2018

Summary

From API, make support_oppose_indicator sortable on ScheE endpoint.

API endpoint that is modified under Independent Expenditures:
/schedules/schedule_e/

Include a summary of proposed changes.

  1. Make support_oppose_indicator sortable
  2. Add tests to sort(asc,desc order) by support_oppose_indicator column

How to test the changes locally

  1. checkout feature/make-support-oppose-indicator-column-sortable-scheduleE

  2. Sort by support_oppose_indicator in descending order :::

  3. ascending order:::

Impacted areas of the application

Independent Expenditures datatables. This will give the ability to sort by support/oppose column on the website

…column sortable. This gives the ability to sort by this column from the IE data pages on the frontend.
@pkfec
Copy link
Contributor Author

pkfec commented Nov 30, 2018

@hcaofec @fec-jli @lbeaufort Please review this PR when you get a chance.

@fec-jli
Copy link
Contributor

fec-jli commented Nov 30, 2018

good. It works well.
one more thing: Can you make all descriptions into key-value of docs.py
for schedule_e = {...} section in args.py? make python code clear. Thanks

@pkfec
Copy link
Contributor Author

pkfec commented Dec 3, 2018

@fec-jli Like you suggested, I moved all the schedule_e args to docs.py. This PR is ready for review again.

@codecov-io
Copy link

Codecov Report

Merging #3520 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3520      +/-   ##
===========================================
+ Coverage    88.01%   88.02%   +0.01%     
===========================================
  Files           76       76              
  Lines         6441     6448       +7     
===========================================
+ Hits          5669     5676       +7     
  Misses         772      772
Impacted Files Coverage Δ
webservices/resources/sched_e.py 77.55% <ø> (ø) ⬆️
webservices/args.py 97.58% <ø> (ø) ⬆️
webservices/docs.py 100% <100%> (ø) ⬆️
webservices/legal_docs/current_cases.py 87.39% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b7cca8...594e9ce. Read the comment docs.

Copy link
Contributor

@fec-jli fec-jli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good. Thanks

@fec-jli fec-jli merged commit 96fb6d7 into develop Dec 3, 2018
@pkfec pkfec deleted the feature/make-support-oppose-indicator-column-sortable-scheduleE branch December 4, 2018 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants