Remove mur-specific query fields - use 'case'

[lbeaufort]

Summary (required)

• Resolves Remove the mur_ filters from the API #3504
• Remove mur-specific query fields - use case_
• Fix admin fine filter typo

How to test the changes locally

• Run ES locally, do a mur query: http://localhost:5000/v1/legal/search/?case_no=7400

Impacted areas of the application

List general components of the application that this PR will affect:

• MUR search

[codecov-io]

Codecov Report

Merging #3505 into develop will increase coverage by 0.12%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #3505      +/-   ##
===========================================
+ Coverage    88.14%   88.27%   +0.12%     
===========================================
  Files           76       76              
  Lines         6420     6396      -24     
===========================================
- Hits          5659     5646      -13     
+ Misses         761      750      -11

Impacted Files	Coverage Δ
webservices/resources/legal.py	72.55% <0%> (+1.84%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b328d2...db06ba1. Read the comment docs.

[qqss88]

everything look great to me.

[fec-jli]

I have two questions when I review on local.
1)I load 3 Murs into local ES. when I run http://localhost:5000/v1/legal/search/?case_no=7400
it works well. return one mur(7400)
if I run old field name like: http://localhost:5000/v1/legal/search/?mur_no=7400
I got all 3 murs return. Is this ok? we control field name from cms side?

2)if I run DSL to check mur data on local (new field name)
curl localhost:9200/docs/murs/case_7400 | python -m json.tool
no result.

I have to run this and get result (old field name):
curl localhost:9200/docs/murs/mur_7400 | python -m json.tool

not sure these two questions related with this ticket or not. Thank You.

[lbeaufort]

@fec-jli thanks for taking a look!

if I run old field name like: http://localhost:5000/v1/legal/search/?mur_no=7400
I got all 3 murs return. Is this ok? we control field name from cms side?

Yes, because we're removing mur_no as a parameter, the filter won't work, and will return all results

2)if I run DSL to check mur data on local (new field name)
curl localhost:9200/docs/murs/case_7400 | python -m json.tool
no result.
I have to run this and get result (old field name):
curl localhost:9200/docs/murs/mur_7400 | python -m json.tool

This query uses the doc_id, which will start with the case type (in your example, mur_7400). doc_id needs to be unique, and some cases have the same number (something like AF 100, ADR 100).

openFEC/webservices/legal_docs/current_cases.py

Line 242 in 2b7cca8

'doc_id': '{0}_{1}'.format(case_type.lower(), row['case_no']),