Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MERGE WITH GIT FLOW] Show 2020 house candidate history #3485

Merged
merged 1 commit into from
Nov 9, 2018

Conversation

lbeaufort
Copy link
Member

@lbeaufort lbeaufort commented Nov 9, 2018

Summary (required)

Show history for first-time, future-cycle house candidates. This has already been merged to develop but @jwchumley requested a hotfix

See original PR: #3483

Resolves fecgov/fec-cms#2463

For new house candidates that file for a future election,
  the 2-year period will equal `prev_election_yr`
  until we reach the 2-year period for that future election.

This `>=` (rather than `>`) guarantees results for candidate pages.

A `SELECT DISTINCT` on `candidate_id` prevents duplicate rows.
@lbeaufort lbeaufort changed the base branch from develop to master November 9, 2018 16:18
@lbeaufort lbeaufort added the Hotfix Merge with git flow label Nov 9, 2018
@pkfec pkfec self-requested a review November 9, 2018 16:39
@pkfec
Copy link
Contributor

pkfec commented Nov 9, 2018

Nice work @lbeaufort

@pkfec pkfec merged commit 2a04e43 into master Nov 9, 2018
@lbeaufort lbeaufort deleted the hotfix/show-2020-house-cand-history branch November 16, 2018 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hotfix Merge with git flow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants