Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use full text filter for aggregate resources #3423

Merged
merged 1 commit into from
Oct 12, 2018

Conversation

lbeaufort
Copy link
Member

@lbeaufort lbeaufort commented Oct 9, 2018

Use fulltext filter for:
Schedule A: employer, occupation
Schedule B: purpose, and recipient name

Summary (required)

How to test the changes locally

Impacted areas of the application

List general components of the application that this PR will affect:

  • /schedule_a/by_employer/ -> Can use partial text search for employer
  • /schedule_a/by_occupation/ -> "" occupation
  • /schedule_b/by_purpose/ -> "" purpose
  • /schedule_b/by_recipient/ -> "" recipient

Use fulltext filter for:
Schedule A: employer, occupation
Schedule B: purpose, and recipient name

This allows partial matches on these text fields
@codecov-io
Copy link

codecov-io commented Oct 9, 2018

Codecov Report

Merging #3423 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3423      +/-   ##
===========================================
+ Coverage    88.47%   88.48%   +<.01%     
===========================================
  Files           76       76              
  Lines         6328     6332       +4     
===========================================
+ Hits          5599     5603       +4     
  Misses         729      729
Impacted Files Coverage Δ
webservices/schemas.py 86.3% <ø> (ø) ⬆️
webservices/resources/aggregates.py 96.71% <100%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd3c7fc...a895bbf. Read the comment docs.

Copy link
Contributor

@pkfec pkfec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@pkfec
Copy link
Contributor

pkfec commented Oct 12, 2018

@qqss88 Can you merge this PR after you are done testing?

@lbeaufort
Copy link
Member Author

@pkfec I don't think Charlie can merge PR's yet.

@pkfec pkfec closed this Oct 12, 2018
@pkfec pkfec reopened this Oct 12, 2018
@pkfec pkfec merged commit fe37a74 into develop Oct 12, 2018
@pkfec pkfec deleted the feature/fix-aggregate-filters branch October 12, 2018 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants