Fix elections endpoint to handle per_page=0 #3303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setup cap=0
pkfec
reviewed
Jul 24, 2018
| @@ -128,6 +129,19 @@ def args(self): | |||
| ), | |||
| ) | |||
|
|
|||
| def get(self, *args, **kwargs): | |||
| query = self.build_query(*args, **kwargs) | |||
| count = counts.count_estimate(query, models.db.session, threshold=500000) | |||
There was a problem hiding this comment.
Any reason why the threshold is set to high value?
lbeaufort
approved these changes
Jul 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
when fec-cms pass per_page=0 (means: get all results, don't do pagination),
the elections endpoint not handle this case,
so set cap=0 to avoid doing pagination.
related PR: #3292
How to test locally:
2)DB--dev
3)loach cms point to local api
4)test elections summary pages to make sure all data sets result correctly.