Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Add pgTap test for amendment chain view #3268

Closed
wants to merge 1 commit into from

Conversation

vrajmohan
Copy link
Contributor

Install pgTap using https://pgtap.org/documentation.html.

Run the tests using pg_prove --verbose -d fectest tests/sql/efiling_amendment_chain.sql

@codecov-io
Copy link

Codecov Report

Merging #3268 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3268      +/-   ##
===========================================
+ Coverage    88.12%   88.13%   +0.01%     
===========================================
  Files           75       76       +1     
  Lines         6087     6102      +15     
===========================================
+ Hits          5364     5378      +14     
- Misses         723      724       +1
Impacted Files Coverage Δ
webservices/partition/__init__.py 100% <0%> (ø) ⬆️
webservices/partition/sched_b.py 92.85% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 721e71d...5dd8212. Read the comment docs.

@lbeaufort
Copy link
Member

We've decided to stick with pytest for testing SQL / MV logic. Example: https://github.com/fecgov/openFEC/blob/develop/tests/integration/test_amendment_chain.py#L14

@lbeaufort lbeaufort closed this Nov 23, 2018
@lbeaufort lbeaufort deleted the feature/add-pgtap-test branch June 21, 2019 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants