Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sched_e MV to support sort on non-standard s_o_ind value #3532

Closed
fecjjeng opened this issue Dec 7, 2018 · 2 comments
Closed

Update sched_e MV to support sort on non-standard s_o_ind value #3532

fecjjeng opened this issue Dec 7, 2018 · 2 comments
Assignees
Milestone

Comments

@fecjjeng
Copy link
Contributor

fecjjeng commented Dec 7, 2018

While implementing fec-cms issue #2494 Support/Oppose sort on IE table not functioning
fecgov/fec-cms#2494
It had been noticed some rows with s_o_indicator 'unknow' in the front-end always shown on top, despite sort null first or null last. After further investigation, it is revealed the s_o_ind column has non standard (should be 'S' or 'O' or NULL) value which caused the problem. It need to be handled in the data level.

[] Update ofec_sched_e_mv to support sort on non-standard s_o_ind value

@fecjjeng
Copy link
Contributor Author

fecjjeng commented Dec 7, 2018

The problem is s_o_ind column includes values that are not standard 'S' and 'O', which offset the sorting.
"0";3
"A";35
"O";438620
"S";621794
"SUP";37
"UNI";188
"";101749

The sorting is on s_o_ind, not the description. The description displayed in the front end is controlled by cms code, not database, based on the database value in the s_o_ind column. In order to make the non S/O rows sorting correctly, we will need to change the value in the s_o_ind column in the MV. It had been agreed that we will replace all the non S/O values with null in the s_o_ind column. This way we can handle all the strange values yet to come, and no additional cms changes needed.

@fecjjeng
Copy link
Contributor Author

PR #3533 had been merged to DEV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant