Support/Oppose sort on IE table not functioning

[JonellaCulmer]

The sort filter for Support/Oppose column on IE datatable is not currently functioning.

Need to identify the cause and fix as necessary.

[pkfec]

To make the support/oppose column sortable, requires an API change on SE endpoint. There is no ticket to track the API changes. @lbeaufort Can you please create API ticket for this?

[pkfec]

@lbeaufort i have created a new API ticket to enable the sort on ScheE endpoint by support_oppose_indicator column. fecgov/openFEC#3518

The work on API is done. I will submit a PR and have you or someone in our team review it.

[pkfec]

@JonellaCulmer The API PR to enable support/oppose indicator on Independent Expenditures is merged to develop branch. fecgov/openFEC#3518

Can you test the sort by support/oppose on IE datatables in dev environment?

[JonellaCulmer]

@pkfec The sort is working now on dev! But I noticed that regardless of which you're sorting by, there are "unknown"s that appear. Do we know how these are populating on the list?

[pkfec]

Sort on suppose/oppose indicator column is not working because this column values are inconsistent. The column value in the backend is not always S or O. @fecjjeng identified that there are other values like 0(ZERO), UNI, SUP and Nulls.

Reached out to @jwchumley and waiting to hear from him on how to manipulate the data when the support/oppose indicator values either one of these : 0( ZERO), UNI, SUP and Nulls

[pkfec]

after talking to @jwchumley @PaulClark2 , we all agreed to replace the non S/O values with NULL.
@fecjjeng is working on updating the s_o_ind column on SE MV here:fecgov/openFEC#3532

[pkfec]

@JonellaCulmer the backend MV changes are merged into Dev environment. You can now test the support/oppose sort on IE screen.

[pkfec]

@JonellaCulmer did you get a chance to test this bug in Dev environment?

[JonellaCulmer]

@pkfec So that I understand, I should no longer see Unknown, but null? I'm only seeing Support or Oppose.

[pkfec]

@JonellaCulmer Nulls on the backend are mapped to Unknowns on the CMS. Sorting is based off S/O value and not by Unknown. The Unknowns are always sorted last and they always appear at the end of the results when you sort asc or desc order on the support/oppose column.

Here is an example of IE committee with support/oppose and unknowns values. Try sorting the column and see if that makes sense.
https://fec-dev-cms.app.cloud.gov/data/independent-expenditures/?data_type=processed&committee_id=C90009358&cycle=2006&cycle=2012&is_notice=true&candidate_office=H&candidate_office_state=MI&candidate_office_state=NJ

Hope this helps!

[JonellaCulmer]

@pkfec I understand! Thanks so much! Looks great to me!

[JonellaCulmer]

The PR work related to this work has been merged and the fix has been reviewed. So closing this issue.