Feature/election summary #610
Conversation
| this.$disbursements = this.$elm.find('.disbursements'); | ||
|
|
||
| this.fetch(); | ||
| this.$elm.find('a.button--election').attr('href', this.buildUrl()); |
There was a problem hiding this comment.
Is the a in the selector actually needed?
I'd also suggest this should be a js-prefixed class rather then using a styling class, but will defer to you for best judgement.
There was a problem hiding this comment.
I think the a makes sense, since this behavior can only apply to anchor tags. Agreed re. js- prefixed classes; will update.
|
Updated! |
|
The "view all" link in the summary has the wrong URL "http://localhost:3000/president/2016/". Missing "/elections/" |
|
Other than that looks good to me whenever the api update gets merged. It's a little slow for me running the api locally, but hopefully that's helped when it's not local. If not, may be worth adding a loading animation or something. Or, like, a cool ticker effect. |
|
I think if we are showing candidate totals, we need independent expenditure totals for that race too. |
|
This looks good, I think we need to add independent expenditures to this, but that can be a separate pr. |
Add election summary data to homepage. Completes #591.
Branched off #605.
Depends on https://github.com/18F/openFEC/pull/1188.