This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Principal committees are in committees_authorized so they weren't showing #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -35,7 +35,7 @@ <h5 class="entity__term__label">District</h5> | |||
| <h5 class="entity__term__label"> | |||
| <a class="term" data-term="Principal Campaign Committee">Principal Committee</a> | |||
| </h5> | |||
| {% for c in committees if c.designation == 'P' %} | |||
| {% for c in committees_authorized if c.designation == 'P' %} | |||
There was a problem hiding this comment.
To loop over all principal committees, use for c in committee_groups['P']. I noticed that we were looping over all committees several times, so I moved that logic into a groupby in views.py.
There was a problem hiding this comment.
Sounds good. I will make the change
|
This regression ought to have been caught by the test here (or at least a test like it-- tied to the principal committee link specifically)... but it seems it hasn't been run by Travis/caught by the test runner. We should make sure that this test actually does pass with this fix. To invoke just that test: |
|
Oh and I have a fix for the syntax errors in that file here: #246 |
jmcarp
added a commit
that referenced
this pull request
Jun 8, 2015
Principal committees are in committees_authorized so they weren't showing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm bringing Principal Committees back.
fixes 18F/openFEC#917