Feature/datatables #220
Feature/datatables #220
Conversation
|
This is looking much better with updates from @noahmanger. Ready for review @msecret. |
| { | ||
| data: 'name', | ||
| render: function(data, type, row, meta) { | ||
| var anchor = $('<a>'); |
There was a problem hiding this comment.
Can we use $anchor as the var name to specify that it's a jquery element
There was a problem hiding this comment.
Sure, I'll do a pass through the patch and make sure jquery elements are prefixed with $.
Also factor HTML templating for candidate and committee links into a helper function that doesn't use jQuery.
|
Also, this seems to be causing some troubles with the way the tables adjust to smaller screens. I think we may want to look into using the datatables responsive extension: https://www.datatables.net/extensions/responsive/ |
|
@noahmanger @msecret: updated to include datatables css in bundle. |
…-app into feature/datatables
Also import vendor styles before custom styles such that our styles get higher priority.
jmcarp
force-pushed
the
feature/datatables
branch
from
6a3428a to
f13e6e1
Compare
|
I'd merge this but there's some conflicts in view.py and I'm not sure what to do there. |
|
I'll fix conflicts tonight. |
|
Conflicts fixed @noahmanger. One test is still expected to fail--I submitted #237 to fix that. |
Render candidate and committee tables with DataTables.
This patch is using 100% DataTables defaults style-wise and will definitely need some review on that front. @noahmanger or @msecret, any suggestions or sub-PRs on style would be much appreciated, since I'm not very familiar with the webapp styles.