Handle empty reports and totals.

Plus regression tests! [fixes https://github.com/18F/openFEC/issues/563]
fecgov · Apr 9, 2015 · 5b6ee5a · 5b6ee5a
1 parent 37d4663
commit 5b6ee5a
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 7 deletions.
diff --git a/openfecwebapp/data_prep/financial_summaries.py b/openfecwebapp/data_prep/financial_summaries.py
@@ -12,8 +12,8 @@ def _map_committee_financials(vals):
     from the 'totals' endpoint for use on candidate
     and committee pages
     """
-    reports = vals['reports'][0]
-    totals = vals['totals'][0]
+    reports = vals['reports'][0] if vals['reports'] else {}
+    totals = vals['totals'][0] if vals['totals'] else {}
     totals_mapped = {}
     value_map = {
         'total_receipts': totals.get('receipts'),

diff --git a/openfecwebapp/tests/data_prep/financial_summaries_tests.py b/openfecwebapp/tests/data_prep/financial_summaries_tests.py
@@ -1,7 +1,10 @@
+import copy
 import unittest
+
 from openfecwebapp.data_prep.financial_summaries import  _map_committee_financials
 from openfecwebapp.tests.mock_data import *
 
+
 class TestFinancialSummaries(unittest.TestCase):
 
     def test_map_committee_financials(self):
@@ -21,3 +24,17 @@ def test_map_committee_financials(self):
         self.assertEqual('$0.00', c['total_disbursements'])
         self.assertEqual('$0.00', c['total_cash'])
         self.assertEqual('$0.00', c['total_debt'])
+
+    def test_map_committee_financials_empty_reports(self):
+        result = copy.deepcopy(totals['results'][0])
+        result['reports'] = []
+        res = _map_committee_financials(result)
+        self.assertNotIn('total_cash', res)
+        self.assertNotIn('total_debt', res)
+
+    def test_map_committee_financials_empty_totals(self):
+        result = copy.deepcopy(totals['results'][0])
+        result['totals'] = []
+        res = _map_committee_financials(result)
+        self.assertNotIn('total_receipts', res)
+        self.assertNotIn('total_disbursements', res)
diff --git a/openfecwebapp/tests/mock_data.py b/openfecwebapp/tests/mock_data.py
@@ -26,7 +26,7 @@
                 'committee_id': 'D1234',
                 'committee_name': 'Friends of McPersonson',
                 'committee_designation': 'A',
-                'committee_designation_full': 'Authorized committee' 
+                'committee_designation_full': 'Authorized committee'
             }
         ]
     }],
@@ -35,14 +35,14 @@
         'committee_id': 'D1234',
         'name': 'Friends of McPersonson',
         'designation_full': 'Authorized',
-        'designation_code': 'PC' 
+        'designation_code': 'PC'
     },
     'affiliated_committees': {
         'D1234': {
             'id': 'D1234',
             'name': 'Friends of McPersonson',
             'designation_full': 'Authorized',
-            'designation_code': 'A' 
+            'designation_code': 'A'
         }
     }
 }
@@ -103,7 +103,7 @@
         'committee_id': 'D1234',
         'committee_name': 'Friends of McPersonson',
         'designation_full': 'Authorized',
-        'designation_code': 'A' 
+        'designation_code': 'A'
 
     }
 ]
@@ -113,7 +113,7 @@
         'committee_id': 'D1234',
         'committee_name': 'Friends of McPersonson',
         'designation_full': 'Authorized',
-        'designation_code': 'A' 
+        'designation_code': 'A'
     }
 }