Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md local dev instructions #2348

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Conversation

lbeaufort
Copy link
Member

@lbeaufort lbeaufort commented Nov 6, 2024

add npm install instructions, replace ng serve with npx -p @angular/cli ng serve

add `npm install` instructions
@lbeaufort lbeaufort changed the title Update README.md Update README.md local dev instructions Nov 6, 2024
@lbeaufort
Copy link
Member Author

@dheitzer thanks for your review! Do you think we need to add npm i -g @angular/cli too? A simple npm install wasn't sufficient for me.

@dheitzer
Copy link
Contributor

@dheitzer thanks for your review! Do you think we need to add npm i -g @angular/cli too? A simple npm install wasn't sufficient for me.

Ah, I'm sorry I didn't notice the question. Actually, I think we may want to change ng serve to npx -p @angular/cli ng serve. This way, the installation is ephemeral and avoids the risk of a global @angular/cli becoming an outdated version. What do you think? @toddlees @Elaine-Krauss-TCG @sasha-dresden curious if anyone else has any thoughts too (this is how I run locally).

@lbeaufort
Copy link
Member Author

@dheitzer thanks for your review! Do you think we need to add npm i -g @angular/cli too? A simple npm install wasn't sufficient for me.

Ah, I'm sorry I didn't notice the question. Actually, I think we may want to change ng serve to npx -p @angular/cli ng serve. This way, the installation is ephemeral and avoids the risk of a global @angular/cli becoming an outdated version. What do you think? @toddlees @Elaine-Krauss-TCG @sasha-dresden curious if anyone else has any thoughts too (this is how I run locally).

Thanks again @dheitzer - I tested npx -p @angular/cli ng serve and that worked well - happy to update the instructions unless anyone objects. I'll take care of this next week

@lbeaufort lbeaufort requested a review from dheitzer November 16, 2024 22:24
@lbeaufort lbeaufort merged commit c5121dd into develop Nov 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants