feature/1564 - Add poller for app updates #2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddlees
requested changes
Sep 27, 2024
| this.confirmationService.confirm({ | ||
| key: 'refresh', | ||
| message: | ||
| 'A new version of the application has been deployed! Would you like to refresh the page to receive the new app?', |
There was a problem hiding this comment.
Good catch that this could be jarring for a user if they're in the middle of something. This ticket is only to refresh when the versions don't match. We're going to need to take this confirmation out or consult with design to get this part added to the ticket.
There was a problem hiding this comment.
Took out the confirmation. Now it instantly refreshes the page
sasha-dresden
force-pushed
the
feature/1564
branch
from
b58f608 to
81a3d85
Compare
|
|
The Sonarcloud "10 New issues" thing gives me pause, but other than that this looks great |
sasha-dresden
force-pushed
the
feature/1564
branch
from
8f67906 to
7476e0f
Compare
|
toddlees
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue FECFILE-1564