Merge pull request #2393 from fecgov/feature/1671

feature/1671 - remove old debug login functionality

.circleci/config.yml

@@ -125,7 +125,7 @@ jobs:
             DB_DOCKERFILE="Dockerfile-e2e" WORKER_DOCKERFILE="Worker_Dockerfile-e2e" API_DOCKERFILE="Dockerfile-e2e" FECFILE_TEST_DB_NAME="postgres"  DJANGO_SECRET_KEY=${E2E_DJANGO_SECRET_KEY} DATABASE_URL=${E2E_DATABASE_URL} FEC_API=${E2E_FEC_API} FEC_API_KEY=${E2E_FEC_API_KEY} MOCK_EFO="True" docker-compose up --build -d
             docker container run --network container:fecfile-api-proxy \
               docker.io/jwilder/dockerize \
-              -wait http://localhost:8080/api/v1/user/login/authenticate \
+              -wait http://localhost:8080/api/v1/status/ \
               -wait-retry-interval 2s \
               -timeout 60s; \
           working_directory: ~/project/fecfile-web-api

front-end/cypress/e2e/pages/loginPage.ts

@@ -61,8 +61,7 @@ function loginDotGovLogin() {
   cy.intercept('POST', 'http://localhost:8080/api/v1/committees/*/activate/').as('ActivateCommittee');
 
   cy.visit('/');
-  cy.get('#dropdownMenuButton').click();
-  cy.get('[data-test="login-dot-gov-login-button"]').click();
+  cy.get('#loginButton').click();
   cy.wait('@GetLoggedIn');
   cy.visit('/login/security-notice');
   cy.get('.p-checkbox-box').click();

front-end/src/app/login/login.module.ts

@@ -2,20 +2,19 @@ import { CommonModule, NgOptimizedImage } from '@angular/common';
 import { NgModule } from '@angular/core';
 import { FormsModule, ReactiveFormsModule } from '@angular/forms';
 import { SharedModule } from 'app/shared/shared.module';
-import { DebugLoginComponent } from './debug-login/debug-login.component';
-import { SecurityNoticeComponent } from './security-notice/security-notice.component';
-import { LoginComponent } from './login/login.component';
-import { DividerModule } from 'primeng/divider';
-import { CardModule } from 'primeng/card';
 import { ButtonModule } from 'primeng/button';
+import { CardModule } from 'primeng/card';
 import { CheckboxModule } from 'primeng/checkbox';
-import { LoginRoutingModule } from './login-routing.module';
+import { DialogModule } from 'primeng/dialog';
+import { DividerModule } from 'primeng/divider';
 import { InputTextModule } from 'primeng/inputtext';
 import { PasswordModule } from 'primeng/password';
-import { DialogModule } from 'primeng/dialog';
+import { LoginRoutingModule } from './login-routing.module';
+import { LoginComponent } from './login/login.component';
+import { SecurityNoticeComponent } from './security-notice/security-notice.component';
 
 @NgModule({
-  declarations: [LoginComponent, DebugLoginComponent, SecurityNoticeComponent],
+  declarations: [LoginComponent, SecurityNoticeComponent],
   imports: [
     CommonModule,
     FormsModule,

front-end/src/app/login/login/login.component.html

@@ -14,38 +14,9 @@ <h1 class="login-box-header header-productivity">Built to work anywhere.</h1>
       </span>
     </p>
     <div class="button-container">
-      <button *ngIf="!this.localLoginAvailable" (click)="navigateToLoginDotGov()" class="login-button" type="button">
+      <button (click)="navigateToLoginDotGov()" class="login-button" type="button" id="loginButton">
         Sign in with Login.gov
       </button>
-      <div *ngIf="this.localLoginAvailable" class="dropdown d-inline-flex">
-        <button
-          class="btn btn-secondary dropdown-toggle login-button"
-          type="button"
-          id="dropdownMenuButton"
-          data-toggle="dropdown"
-          aria-haspopup="true"
-          aria-expanded="false"
-        >
-          Login
-        </button>
-        <div
-          [style.display]="isDropdownOpen ? 'block' : 'none'"
-          class="dropdown-menu"
-          aria-labelledby="dropdownMenuButton"
-        >
-          <button
-            class="dropdown-item"
-            (click)="navigateToLoginDotGov()"
-            type="button"
-            data-test="login-dot-gov-login-button"
-          >
-            Sign in with Login.gov
-          </button>
-          <button class="dropdown-item" (click)="showDebugLogin()" type="button" data-test="debug-login-button">
-            Debug Login
-          </button>
-        </div>
-      </div>
     </div>
     <div class="">
       <a class="learn-more-link" href="https://www.login.gov/what-is-login/">Learn more about Login.gov</a>
@@ -81,9 +52,3 @@ <h1 class="login-box-header header-productivity">Built to work anywhere.</h1>
     </div>
   </div>
 </div>
-
-<p-dialog [(visible)]="isDebugOpen" [style]="{ width: '90%' }" header="Debug Login" [modal]="true">
-  <ng-template pTemplate="content">
-    <app-debug-login></app-debug-login>
-  </ng-template>
-</p-dialog>

front-end/src/app/login/login/login.component.scss

@@ -1,14 +1,3 @@
-.dropdown-menu {
-  top: 25px;
-}
-
-.dashboard-example-img {
-  width: 600px;
-  position: absolute;
-  max-height: calc(100vh - 350px);
-  overflow: hidden;
-}
-
 .login-box-header {
   font-family: 'karla-bold', Sans-serif;
   font-size: 32px;
@@ -43,10 +32,6 @@
 .login-button {
   color: #ffffff;
   background-color: #112e51;
-}
-
-.login-button,
-.signup-button {
   border-radius: 4px;
   display: inline-block;
   font-family: 'karla', Sans-serif;
@@ -58,11 +43,6 @@
   vertical-align: middle;
 }
 
-.signup-button {
-  background-color: #35bdbb;
-  color: #212121;
-}
-
 .learn-more-link {
   font-family: 'karla-bold', Sans-serif;
   font-size: 14px;
@@ -73,10 +53,6 @@
   transition: color 0.1s linear;
 }
 
-.debug-login {
-  margin-right: 60px;
-}
-
 .login-page {
   width: 100%;
   max-width: 800px;