Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/1875 - Add CommitteeOwnedMixin tests for both Models and Views #1257

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Feature/1875 - Add CommitteeOwnedMixin tests for both Models and Views #1257

merged 3 commits into from
Jan 22, 2025

Conversation

sasha-dresden
Copy link
Contributor

Issue FECFILE-1875

@sasha-dresden
Added tests to make sure all Views use CommitteeOwnedViewMixin and al…
094451d 
…l models use CommitteeOwnedModel, with some exceptions
@sasha-dresden
Instead of using a file search to find all the ViewSet, made use of t…
3f73126 
…he django routers to identify all the ViewSets
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Elaine-Krauss-TCG
Elaine-Krauss-TCG approved these changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@Elaine-Krauss-TCG Elaine-Krauss-TCG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving after the recent(ish) changes

@exalate-issue-sync exalate-issue-sync bot mentioned this pull request Jan 6, 2025
Open
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@toddlees toddlees merged commit 475e7bc into develop Jan 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dheitzer dheitzer dheitzer approved these changes

@Elaine-Krauss-TCG Elaine-Krauss-TCG Elaine-Krauss-TCG approved these changes

@toddlees toddlees toddlees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sasha-dresden @toddlees @Elaine-Krauss-TCG @dheitzer