This repository has been archived by the owner on Sep 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Modified deployment pipeline to deploy to cloud.gov, fixed some linting errors #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbeaufort
force-pushed
the
feature/28-deploy-to-cloud.gov
branch
2 times, most recently
from
February 18, 2022 17:23
4adb99d
to
8b3eb89
Compare
lbeaufort
force-pushed
the
feature/28-deploy-to-cloud.gov
branch
from
February 18, 2022 17:51
8b3eb89
to
1340577
Compare
lbeaufort
changed the title
[WIP] Modified deployment pipeline to deploy to cloud.gov
Modified deployment pipeline to deploy to cloud.gov, fixed some linting errors
Feb 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a note about the dev branch in tasks.py you should look at.
SonarCloud Quality Gate failed. 4 Bugs |
albertcrowley
approved these changes
Feb 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Approving code review.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FEC_CF_USERNAME_<SPACE>
andFEC_CF_PASSWORD_<SPACE>
in CircleCI using creds in thefecfile-img-deployer-key
service account (See https://cloud.gov/docs/services/cloud-gov-service-account/)Example testing URL: http://0.0.0.0:8080/v1/app-name