Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Modified deployment pipeline to deploy to cloud.gov, fixed some linting errors #33

Merged
merged 10 commits into from
Feb 22, 2022

Conversation

lbeaufort
Copy link
Member

@lbeaufort lbeaufort commented Feb 17, 2022

  • Modified deployment pipeline to deploy to cloud.gov
  • Set up FEC_CF_USERNAME_<SPACE> and FEC_CF_PASSWORD_<SPACE> in CircleCI using creds in the fecfile-img-deployer-key service account (See https://cloud.gov/docs/services/cloud-gov-service-account/)
  • Fixed some linting errors
  • Cleaned up conflicting/unused imports. Let Flask dictate its dependency versions.

Example testing URL: http://0.0.0.0:8080/v1/app-name

@lbeaufort lbeaufort force-pushed the feature/28-deploy-to-cloud.gov branch 2 times, most recently from 4adb99d to 8b3eb89 Compare February 18, 2022 17:23
@lbeaufort lbeaufort force-pushed the feature/28-deploy-to-cloud.gov branch from 8b3eb89 to 1340577 Compare February 18, 2022 17:51
@lbeaufort lbeaufort changed the title [WIP] Modified deployment pipeline to deploy to cloud.gov Modified deployment pipeline to deploy to cloud.gov, fixed some linting errors Feb 18, 2022
Copy link
Contributor

@albertcrowley albertcrowley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a note about the dev branch in tasks.py you should look at.

tasks.py Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 4 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 163 Code Smells

1.2% 1.2% Coverage
22.9% 22.9% Duplication

Copy link
Contributor

@albertcrowley albertcrowley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Approving code review.

@lbeaufort lbeaufort requested a review from mjtravers February 18, 2022 19:08
@mjtravers mjtravers merged commit a563bd4 into develop Feb 22, 2022
@mjtravers mjtravers deleted the feature/28-deploy-to-cloud.gov branch February 22, 2022 14:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants