Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Added flake8 to check for Python linting issues #31

Merged
merged 3 commits into from
Feb 14, 2022
Merged

Conversation

albertcrowley
Copy link
Contributor

@albertcrowley albertcrowley commented Feb 14, 2022

This will add the flake8 lint test to the CircleCI test job.

It has not been configured to ignore any of the legacy code issues so the job will fail if the PR is merged as-is. If we would like to prevent the failed job, we can add the flake8 issue codes to the .flake8 config file to suppress them.

@albertcrowley albertcrowley marked this pull request as draft February 14, 2022 16:51
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@albertcrowley albertcrowley changed the title Feature/flake8 Added flake8 to check for Python linting issues Feb 14, 2022
@albertcrowley albertcrowley marked this pull request as ready for review February 14, 2022 17:14
Copy link
Contributor

@mjtravers mjtravers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@mjtravers mjtravers merged commit a1a977f into develop Feb 14, 2022
@mjtravers mjtravers deleted the feature/flake8 branch February 14, 2022 20:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants