Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update redirects-transition.conf #276

Merged
merged 3 commits into from
Jul 20, 2021
Merged

Update redirects-transition.conf #276

merged 3 commits into from
Jul 20, 2021

Conversation

kathycarothers
Copy link
Contributor

I have updated the presidential matching funds submission pages from transitions to wagtail. The need to be reviewed and deployed.

I have updated the presidential matching funds submission pages from transitions to wagtail.
Copy link
Contributor

@dorothyyeager dorothyyeager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me Kathy. Thank you so much for working on this particular project.

Adding to @kathycarothers' branch off dev. This commit adds several missed redirects from previous rounds of redirects and it includes several new redirects identified in the 7/13 transition inventory meeting.
@bmathesonFEC
Copy link
Contributor

bmathesonFEC commented Jul 17, 2021

I just made a commit to Kathy's branch off of dev. Added a few previously missed redirects and new redirects identified in the 7/13 transition inventory meeting.

This is PR should also be connected to:

Copy link
Member

@patphongs patphongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kathycarothers Just one minor change:

rewrite ^/law/cfr/11_cfr.pdf https://www.govinfo.gov/content/pkg/CFR-2010-title11-vol1/pdf/CFR-2010-title11-vol1.pdf redirect;
rewrite ^/law/cfr/2014cfr.pdf https://www.govinfo.gov/content/pkg/CFR-2014-title11-vol1/pdf/CFR-2014-title11-vol1.pdf redirect;
rewrite ^/law/cfr/11cfr2015.pdf https://www.govinfo.gov/content/pkg/CFR-2015-title11-vol1/pdf/CFR-2015-title11-vol1.pdf redirect;
xrewrite ^/law/cfr/ej_citation.shtml https://www.fec.gov/legal-resources/regulations/explanations-and-justifications/explanations-and-justifications-citation-index/ redirect;
Copy link
Member

@patphongs patphongs Jul 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kathycarothers Please change from xrewrite to rewrite at the beginning of line 437.

I have corrected the error for line 437
Copy link
Member

@patphongs patphongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @kathycarothers!

@patphongs patphongs merged commit be40d2b into develop Jul 20, 2021
@pkfec pkfec deleted the kcarothers-cms-4594 branch May 15, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants