Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirects for pages identified in transition inventory meeting 14.6 #268

Merged
merged 3 commits into from
Jun 8, 2021

Conversation

bmathesonFEC
Copy link
Contributor

Summary

Redirects identified in transition inventory meeting 14.6

Resolves cms #4619

### Summary
Redirects identified in transition inventory meeting 14.6

Resolves CMS #4619
Copy link
Contributor

@dorothyyeager dorothyyeager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two lines need a / added. That was a lot of redirecting; thank you for taking it on!

redirects-transition.conf Show resolved Hide resolved
minor edits to redirects based on comments. Resolved in conversations.
@bmathesonFEC
Copy link
Contributor Author

I made the edits... and marked them as resolved but it now occurs to me that I'm probably supposed to let the reviewers mark them as resolved!

Caught more missed slashes at the front of the redirect "from" paths.
Copy link
Contributor

@dorothyyeager dorothyyeager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @patphongs the only one I'm not sure about was the redirect that points to a PDF page number.

Copy link
Member

@patphongs patphongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Page number seems to redirect ok when I tested it locally. Thanks @bmathesonFEC @dorothyyeager

@patphongs patphongs merged commit ead8104 into master Jun 8, 2021
@lbeaufort lbeaufort deleted the bmathesonFEC-cms-4619 branch June 22, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants