Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redirects for RAD FAQ transition pages #267

Merged
merged 2 commits into from
Jun 8, 2021
Merged

Conversation

bmathesonFEC
Copy link
Contributor

Summary

Redirects RAD FAQ pages and documents linked on the RAD FAQ transition page.
Resolves cms #4628

###Summary
Redirects RAD FAQ pages and documents linked on the RAD FAQ transition page.
Resolves #4628
@bmathesonFEC
Copy link
Contributor Author

@kathycarothers @djgarr I tagged Dorothy, but she certainly doesn't need to be the reviewer on this redirect PR.

Also, I want to highlight the fact that there were two links on the RAD FAQ page that weren't in the /rad/ section:

  • a brochure in the /pages/ redirect section
  • a link to an image search page (that looks like it was already pulled down) which meant I head to create a whole section for /finance/

@kathycarothers
Copy link
Contributor

@bmathesonFEC @dorothyyeager @patphongs For the broader redirect listed below I think you might need a $1 in the second URL address at the end. Though I could be wrong on this. That is why I am including Dorothy and Pat.

# /rad/ broader redirectsrewrite ^/rad/(.*) https://www.fec.gov/help-candidates-and-committees/ redirect;

Everything else looks good. I don't think David nor I can approve or comment in the review section if we are not listed as reviewers. I could be wrong.

@dorothyyeager
Copy link
Contributor

Hey @bmathesonFEC - Let's tag Kathy and Pat as reviewers for this PR since Kathy caught something. I think there is a specific order for merging redirect PRs so there's no conflicts and @patphongs will know more about that.

Copy link
Contributor

@kathycarothers kathycarothers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the broader redirect listed below I think you might need a $1 in the second URL address at the end. Though I could be wrong on this.

/rad/ broader redirectsrewrite ^/rad/(.*) https://www.fec.gov/help-candidates-and-committees/ redirect;

so it would be https://www.fec.gov/help-candidates-and-committees/$1 redirect;

Copy link
Member

@patphongs patphongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bmathesonFEC, just two minor edits.

redirects-transition.conf Outdated Show resolved Hide resolved
redirects-transition.conf Outdated Show resolved Hide resolved
@patphongs
Copy link
Member

patphongs commented Jun 5, 2021

@bmathesonFEC @dorothyyeager @patphongs For the broader redirect listed below I think you might need a $1 in the second URL address at the end. Though I could be wrong on this. That is why I am including Dorothy and Pat.

/rad/ broader redirectsrewrite ^/rad/(.*) https://www.fec.gov/help-candidates-and-committees/ redirect;

Everything else looks good. I don't think David nor I can approve or comment in the review section if we are not listed as reviewers. I could be wrong.

@bmathesonFEC @kathycarothers if the pages under the /rad/ directory on transition will broadly go to just the single landing page of Help for candidates and committees, then we don’t need the ‘$1’ since we are not trying to pattern match the URL with the original URL. The specific redirects that were made above this broad RAD redirect will override this rule, so those should follow correctly. Let me know if you need additional clarification. Thanks!

@JonellaCulmer JonellaCulmer added this to the PI 14 Innovation milestone Jun 7, 2021
second commit on this branch to resolve comments on the PR.
@bmathesonFEC
Copy link
Contributor Author

Marked the comments on the PR as resolved. Not sure whether or not I was supposed to leave those conversations for you to resolve.

Copy link
Member

@patphongs patphongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bmathesonFEC, looks good!

@patphongs patphongs merged commit 1a11e15 into master Jun 8, 2021
@lbeaufort lbeaufort deleted the bmathesonFEC-cms-4628 branch June 22, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants